Skip to content

fix: raise ValueError on duplicate subtask tags in reorder_subtasks#874

Open
sjoerdvink99 wants to merge 1 commit intogenerative-computing:mainfrom
sjoerdvink99:fix/864-duplicate-subtask-tags
Open

fix: raise ValueError on duplicate subtask tags in reorder_subtasks#874
sjoerdvink99 wants to merge 1 commit intogenerative-computing:mainfrom
sjoerdvink99:fix/864-duplicate-subtask-tags

Conversation

@sjoerdvink99
Copy link
Copy Markdown
Contributor

@sjoerdvink99 sjoerdvink99 commented Apr 16, 2026 •
edited by psschwei
Loading

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue: Fixes

Fixes #864

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

@sjoerdvink99 sjoerdvink99 requested a review from a team as a code owner April 16, 2026 15:05
@github-actions github-actions Bot added the bug Something isn't working label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

AngeloDanducci
AngeloDanducci reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AngeloDanducci AngeloDanducci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @csbobby I'll leave the final say up to you but I think this adequately addresses the issue.

Set the workflows to run.

planetf1
planetf1 approved these changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psschwei
Copy link
Copy Markdown
Member

psschwei commented Apr 21, 2026

@sjoerdvink99 CI is failing
also, can you comment on the issue so we can assign it to you

@sjoerdvink99
Copy link
Copy Markdown
Contributor Author

sjoerdvink99 commented Apr 21, 2026

working on it!

@sjoerdvink99 sjoerdvink99 force-pushed the fix/864-duplicate-subtask-tags branch from c58cfab to d589585 Compare April 21, 2026 17:07
@sjoerdvink99 sjoerdvink99 force-pushed the fix/864-duplicate-subtask-tags branch from d589585 to 1e94360 Compare April 21, 2026 17:13
@sjoerdvink99
Copy link
Copy Markdown
Contributor Author

sjoerdvink99 commented Apr 21, 2026

@psschwei The failing test (test_span_duration_captures_async_operation) seems to be unrelated to the changes in this PR. It is a pre-existing timing test with a 0.5s hardcoded tolerance that flaked on CI due to normal scheduling variance on a 38 second LLM call (observed difference was 0.55s). I will rebase onto main and try to retrigger CI.

@psschwei
Copy link
Copy Markdown
Member

psschwei commented Apr 21, 2026

CI is passing now, @csbobby could you take a look for final approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AngeloDanducci AngeloDanducci AngeloDanducci left review comments

@planetf1 planetf1 planetf1 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: duplicate subtask tags silently drop tasks in reorder_subtasks

4 participants

@sjoerdvink99 @psschwei @planetf1 @AngeloDanducci